4 comments:
File src/mainboard/google/zork/spd/Makefile.inc:
Patch Set #5, Line 17: --hex \
The switch to binary has stalled. So --hex is still needed for now.
Patch Set #5, Line 20: $(if $(APCB_POPULATE_2ND_CHANNEL), --chan_mask 5, --chan_mask 1) \
Where does chan_mask 5 come from?
File src/soc/amd/picasso/Makefile.inc:
Patch Set #3, Line 243: #ifdef SPD_SOURCES
Yes, unfortunately it is needed. […]
Does add_opt_prefix return "" when SPD_BLOB is undefined? This seems fragile. Maybe this ifdef should be around OPT_SPD_BLOB?
Patch Set #5, Line 128: # specifying which channels are actually populated (no need for dedicated GPIO84)
This does not replace GPIO84. GPIO84 is needed on boards that support both 1 and 2 channel dram. On these boards both must be populated. Boards that never support 2 channels need to only populate 1 channel here because GPIO84 isn't set on these boards.
To view, visit change 45278. To unsubscribe, or for help writing mail filters, visit settings.