Shelley Chen submitted this change.

View Change

Approvals: Eran Mitrani: Looks good to me, approved build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
mb/google/rex/var/karis: Follow rex0 CNVi/PCIe switching

Follow reference design rex0, keep the GPIO settings of CNVi/PCIe.
Only set GPP_F04,GPP_F05/GPP_S01,GPP_S02 to NC when
WIFI_PCIE/WIFI_CNVI is selected.

BUG=none
TEST=Build and test on karis

Change-Id: Id23a2cfe0639f2d423980db9badc16c1477434d1
Signed-off-by: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80215
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eran Mitrani <mitrani@google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
---
M src/mainboard/google/rex/variants/karis/fw_config.c
1 file changed, 0 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/google/rex/variants/karis/fw_config.c b/src/mainboard/google/rex/variants/karis/fw_config.c
index 6dbf31d..c209295 100644
--- a/src/mainboard/google/rex/variants/karis/fw_config.c
+++ b/src/mainboard/google/rex/variants/karis/fw_config.c
@@ -35,14 +35,6 @@
};

static const struct pad_config cnvi_bt_disable_pads[] = {
- /* GPP_F00 : [] ==> CNV_BRI_DT_R */
- PAD_NC(GPP_F00, NONE),
- /* GPP_F01 : [] ==> CNV_BRI_RSP */
- PAD_NC(GPP_F01, NONE),
- /* GPP_F02 : [] ==> CNV_RGI_DT_Rl */
- PAD_NC(GPP_F02, NONE),
- /* GPP_F03 : [] ==> CNV_RGI_RSP */
- PAD_NC(GPP_F03, NONE),
/* GPP_F04 : [] ==> CNV_RF_RST_L */
PAD_NC(GPP_F04, NONE),
/* GPP_F05 : [] ==> CNV_CLKREQ */
@@ -54,8 +46,6 @@
PAD_NC(GPP_S01, NONE),
/* GPP_S02 : [] ==> DMIC_SOC_CLK0_WLAN_PCM_OUT */
PAD_NC(GPP_S02, NONE),
- /* GPP_D21 : [] ==> WLAN_CLKREQ_ODLl */
- PAD_NC(GPP_D21, NONE),
};

static const struct pad_config bt_i2s_enable_pads[] = {

To view, visit change 80215. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id23a2cfe0639f2d423980db9badc16c1477434d1
Gerrit-Change-Number: 80215
Gerrit-PatchSet: 6
Gerrit-Owner: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Jack Lai <jack.lai@intel.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang@intel.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged