1 comment:
File src/soc/intel/common/block/reset/reset.c:
Patch Set #7, Line 27: do_force_global_reset
Sure, I just don't like the naming scheme :-)
First, I'd like to find a better name for do_global_reset, since naming whise it's not clear what the difference between global_reset vs. do_global_reset is. That's simply confusing. (another, exaggerated example would be having global_reset, do_global_reset, really_do_global_reset, really_really_do_global_reset, ...) You know what I mean?
Yup 😊
Second, do_global_reset is only ever called from do_force_global_reset, so why not move the prior to the latter?
do_global_reset() is calling from below common reference hence we might need to change that code as well to make something meaning full. Finally do_force_global_reset() can be renamed as pmc_assist_global_reset() which is the actual case ?
vim src/soc/intel/common/reset.c +11
void global_reset(void)
{
printk(BIOS_INFO, "%s() called!\n", __func__);
cf9_reset_prepare();
dcache_clean_all();
do_global_reset();
halt();
}
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.