Is there some quirk with SI_PCH_DEVICE_INTERRUPT_CONFIG that would require entries where arguments device and function would not originate from same PCI BDF?

Also, I do not see fsp2_0/skylake/FspUpdVpd.h anywhere, how does this code work from chip_fsp20.c?

View Change

2 comments:

• File src/soc/intel/skylake/irq.c:

  • Patch Set #1, Line 192: sizeof(SI_PCH_DEVICE_INTERRUPT_CONFIG));

    Who allocates target buffer?

  • Patch Set #1, Line 212: memcpy(params->PxRcConfig, irq_config, PCH_MAX_IRQ_CONFIG);

    Who allocates target buffer? FSP? But PCH_MAX_IRQ_CONFIG is not defined in FSP headers.

To view, visit change 35735. To unsubscribe, or for help writing mail filters, visit settings.