Felix Held submitted this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved

mb/hp/snb_ivb_laptops: Add SMBIOS slot information

Looking at photos and service manuals, all the WLAN slots are short
(half-height) and WWAN slots long (full-height).

Change-Id: I894f8216d1b836fbc41423180177bb8651040fbb
Signed-off-by: Riku Viitanen <riku.viitanen@protonmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80173
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
---
M src/mainboard/hp/snb_ivb_laptops/variants/2170p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb
M src/mainboard/hp/snb_ivb_laptops/variants/probook_6360b/overridetree.cb
8 files changed, 56 insertions(+), 14 deletions(-)

diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/2170p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/2170p/overridetree.cb
index 8e9688f..092049c 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/2170p/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/2170p/overridetree.cb
@@ -29,7 +29,10 @@
 			device ref pcie_rp1 on  end
 			device ref pcie_rp2 off end
 			device ref pcie_rp3 on  end	# SD/MMC
-			device ref pcie_rp4 on  end	# WLAN
+			device ref pcie_rp4 on     	# WLAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthShort" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp5 off end
 			device ref pcie_rp6 off end
 			device ref pcie_rp7 off end
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb
index b1cc9fe..af80813 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb
@@ -25,9 +25,15 @@
 
 			device ref xhci on  end
 			device ref pcie_rp1 on  end
-			device ref pcie_rp2 on  end	# ExpressCard
+			device ref pcie_rp2 on
+				smbios_slot_desc "SlotTypePcmcia" "SlotLengthShort"
+					"ExpressCard Slot" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp3 on  end	# SD/MMC
-			device ref pcie_rp4 on  end	# WLAN
+			device ref pcie_rp4 on     	# WLAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthShort" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp5 off end
 			device ref pcie_rp6 off end
 			device ref pcie_rp7 off end
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb
index 8299cce..9d1890a 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb
@@ -21,12 +21,21 @@
 			register "sata_port_map" = "0x21"
 
 			device ref pcie_rp1 on  end
-			device ref pcie_rp2 on  end	# ExpressCard
+			device ref pcie_rp2 on
+				smbios_slot_desc "SlotTypePcmcia" "SlotLengthShort"
+					"ExpressCard Slot" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp3 on  end	# SD/MMC
-			device ref pcie_rp4 on  end	# WLAN
+			device ref pcie_rp4 on     	# WLAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthShort" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp5 off end
 			device ref pcie_rp6 off end
-			device ref pcie_rp7 on  end	# WWAN
+			device ref pcie_rp7 on     	# WWAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthLong" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp8 off end
 			device ref lpc on
 				chip ec/hp/kbc1126
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb
index b87c80a..bf64099 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb
@@ -23,12 +23,21 @@
 
 			device ref me_kt on  end
 			device ref pcie_rp1 on  end
-			device ref pcie_rp2 on  end	# ExpressCard
+			device ref pcie_rp2 on
+				smbios_slot_desc "SlotTypePcmcia" "SlotLengthShort"
+					"ExpressCard Slot" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp3 on  end	# SD/MMC
-			device ref pcie_rp4 on  end	# WLAN
+			device ref pcie_rp4 on     	# WLAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthShort" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp5 off end
 			device ref pcie_rp6 off end
-			device ref pcie_rp7 on  end	# WWAN
+			device ref pcie_rp7 on     	# WWAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthLong" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp8 on  end	# NEC USB 3.0 Host Controller
 			device ref lpc on
 				chip ec/hp/kbc1126
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb
index b02b2f9..cfc5372 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb
@@ -27,9 +27,15 @@
 			device ref xhci on  end
 			device ref me_kt on  end
 			device ref pcie_rp1 on  end
-			device ref pcie_rp2 on  end	# ExpressCard
+			device ref pcie_rp2 on     	# ExpressCard
+				smbios_slot_desc "SlotTypePcmcia" "SlotLengthShort"
+					"ExpressCard Slot" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp3 on  end	# SD/MMC
-			device ref pcie_rp4 on  end	# WLAN
+			device ref pcie_rp4 on     	# WLAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthShort" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp5 off end
 			device ref pcie_rp6 off end
 			device ref pcie_rp7 off end
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb
index d30f179..f326c40 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb
@@ -29,7 +29,10 @@
 			device ref pcie_rp1 on  end
 			device ref pcie_rp2 on  end
 			device ref pcie_rp3 on  end	# Media Card and FireWire host controller
-			device ref pcie_rp4 on  end	# Wireless LAN Adapter
+			device ref pcie_rp4 on     	# Wireless LAN Adapter
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthShort" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp5 on  end	# SATA Controller 2 for dock
 			device ref pcie_rp6 off end
 			device ref pcie_rp7 off end
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb
index 1e690b5..1e3984d 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb
@@ -27,7 +27,10 @@
 			device ref pcie_rp1 on  end
 			device ref pcie_rp2 off end
 			device ref pcie_rp3 on  end	# SDHCI
-			device ref pcie_rp4 on  end	# WLAN
+			device ref pcie_rp4 on     	# WLAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthShort" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp5 off end
 			device ref pcie_rp6 off end
 			device ref pcie_rp7 off end
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/probook_6360b/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/probook_6360b/overridetree.cb
index b76fe5b..64653bc 100644
--- a/src/mainboard/hp/snb_ivb_laptops/variants/probook_6360b/overridetree.cb
+++ b/src/mainboard/hp/snb_ivb_laptops/variants/probook_6360b/overridetree.cb
@@ -32,7 +32,10 @@
 			end
 			device ref pcie_rp5 off end
 			device ref pcie_rp6 off end
-			device ref pcie_rp7 on  end # WWAN
+			device ref pcie_rp7 on      # WWAN
+				smbios_slot_desc "SlotTypePciExpressMini52pinWithoutBSKO"
+					"SlotLengthLong" "Mini PCIe" "SlotDataBusWidth1X"
+			end
 			device ref pcie_rp8 off end
 			device ref lpc on
 				chip ec/hp/kbc1126

To view, visit change 80173. To unsubscribe, or for help writing mail filters, visit settings.