Patch Set 12:

(1 comment)

This question was addressed in a previous comments as follows:

The changes already present in here will take care of the type 17 new clock units. Another alternative would be to remove the change here and push it down in the FSP codes, the ultimate provider of these information. Which will need to be done for all SOCs since the FSP varies per SOC. .. Past SOCs and GLK (current) for example won't be making the change. Hence the decision to implement it here.

In short, with the x 2 multiplier, no change needed in src/include/memory_info.h

View Change

1 comment:

To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 12
Gerrit-Owner: Francois Toguo Fotso <>
Gerrit-Reviewer: Francois Toguo Fotso <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Francois Toguo Fotso <>
Gerrit-CC: HAOUAS Elyes <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-Comment-Date: Tue, 25 Jun 2019 23:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes <>
Gerrit-MessageType: comment