Attention is currently required from: Xi Chen, Nico Huber, Martin Roth, Paul Menzel, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 )
Change subject: vendor: mediatek: Add mediatek mt8192 dram initialization codes ......................................................................
Patch Set 9:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50294/comment/41c7419d_21efc86b PS9, Line 9: Add the DRAM initialization code based on Mediatek reference implementation. This is the DRAM calibration code from the reference implementation (also known as ETT, EMI Timing Tuning) released by Mediatek for MT8192.
https://review.coreboot.org/c/coreboot/+/50294/comment/52421c37_ecc8cf62 PS9, Line 11: Mediatek internally maintains the DRAM initialization code, following : different coding style. : : To prevent maintaining a different branch for coreboot : (which may lead to typo or errors which switching between different coding : style), we want to directly use the reference implementation as vendor code. The ETT is a standalone library, used by different boot loaders for initializing DRAM and following a different coding style (coreboot was using Linux Kernel coding style) so we have to put it in vendor code folder.
File src/vendorcode/mediatek/mt8192/dram_init.c:
https://review.coreboot.org/c/coreboot/+/50294/comment/b0ca5c62_053d8f2a PS9, Line 59: void _start(void *config) __attribute__((section(".text.start"))); : void _start(void *config) : { : dram_init(config); : } : I think we should remove this if you don't have a plan to build blob here.
File src/vendorcode/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/50294/comment/a3216246_b576d6d7 PS9, Line 1: License this file should be in soc folder.