Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin.
4 comments:
File src/mainboard/google/geralt/panel.c:
if (!panel || panel->disp_path == DISP_PATH_NONE) {
printk(BIOS_ERR, "%s: Panel %u is not supported.\n", __func__, active_panel_id);
return NULL;
}
I think the check can also be moved to `mtk_display_init()`.
File src/soc/mediatek/common/display.c:
Can we return the pointer `&buffer.s` or NULL on error?
nit: No need for parentheses.
File src/soc/mediatek/common/include/soc/display.h:
Patch Set #3, Line 20: struct
const
To view, visit change 79776. To unsubscribe, or for help writing mail filters, visit settings.