Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35495 )
Change subject: trogdor: Provide initial mainboard support
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35495/5/payloads/libpayload/drivers...
File payloads/libpayload/drivers/serial/sc7180.c:
https://review.coreboot.org/c/coreboot/+/35495/5/payloads/libpayload/drivers...
PS5, Line 34: void serial_console_init(void)
This early patch has now been removed.
Ack
https://review.coreboot.org/c/coreboot/+/35495/5/src/mainboard/google/trogdo...
File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/35495/5/src/mainboard/google/trogdo...
PS5, Line 28:
(Note that if you wait with committing sc7180 GPIO support until the patch that adds the implementat […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35495
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2f0944b92dcad7048a0c38720d2ef3c855ef007
Gerrit-Change-Number: 35495
Gerrit-PatchSet: 11
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Oct 2019 23:38:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: mturney mturney
mturney@codeaurora.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment