[coreboot-gerrit] [L] Change in coreboot[main]: mainboard: add Dell Latitude E7240

[Felix Singer (Code Review)]

Attention is currently required from: Arthur Heymans, Iru Cai, Nicholas Chin, Paul Menzel.

Felix Singer has posted comments on this change by Iru Cai. ( https://review.coreboot.org/c/coreboot/+/79746?usp=email )

Change subject: mainboard: add Dell Latitude E7240
......................................................................

Patch Set 5:

(7 comments)

File src/mainboard/dell/e7240/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/79746/comment/a1b329c9_11b5e4c4?usp... :
PS5, Line 5: 	register "gfx" = "GMA_STATIC_DISPLAYS(0)"
           : 	register "gpu_ddi_e_connected" = "0"
           : 	register "gpu_dp_b_hotplug" = "4"
           : 	register "gpu_dp_c_hotplug" = "4"
           : 	register "gpu_dp_d_hotplug" = "4"
           : 	register "panel_cfg" = "{
           : 		.up_delay_ms		= 200,
           : 		.down_delay_ms		=  50,
           : 		.cycle_delay_ms		= 500,
           : 		.backlight_on_delay_ms	=   1,
           : 		.backlight_off_delay_ms	=   1,
           : 		.backlight_pwm_hz	= 200,
           : 	}"
Move into iGPU device scope

https://review.coreboot.org/c/coreboot/+/79746/comment/c4c18dbd_7e833f24?usp... :
PS5, Line 32: 			register "gen1_dec" = "0x007c0681"
            : 			register "gen2_dec" = "0x005c0921"
            : 			register "gen3_dec" = "0x003c07e1"
            : 			# Enable 0x910 and 0x911 for early init and EC driver
            : 		
Move into LPC device scope

https://review.coreboot.org/c/coreboot/+/79746/comment/3487545a_63186b63?usp... :
PS5, Line 43: 			# 0(eSATA on dock), 1(mSATA near the fan), 3(mSATA near WLAN)
            : 		
Move into SATA device scope

File src/mainboard/dell/e7240/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/79746/comment/3933d3de_14c99e38?usp... :
PS5, Line 11: 	AZALIA_PIN_CFG(0, 0x13, 0x411111f0),
```suggestion
    AZALIA_PIN_CFG(0, 0x13, AZALIA_PIN_CFG_NC(0)),
```

https://review.coreboot.org/c/coreboot/+/79746/comment/9be0e9c8_4511092d?usp... :
PS5, Line 15: 	AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
```suggestion
    AZALIA_PIN_CFG(0, 0x18, AZALIA_PIN_CFG_NC(0)),
```

https://review.coreboot.org/c/coreboot/+/79746/comment/5fc15bd4_368c353e?usp... :
PS5, Line 17: 	AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
            : 	A
```suggestion
    AZALIA_PIN_CFG(0, 0x1a, AZALIA_PIN_CFG_NC(0)),
    AZALIA_PIN_CFG(0, 0x1b, AZALIA_PIN_CFG_NC(0)),
```

https://review.coreboot.org/c/coreboot/+/79746/comment/1facf792_75c1c02e?usp... :
PS5, Line 20: 0x411111f0
```suggestion
    AZALIA_PIN_CFG(0, 0x1e, AZALIA_PIN_CFG_NC(0)),
```