9 comments:
File src/northbridge/intel/sandybridge/raminit_common.c:
This was moved to mchbar_regs. […]
Done
empty line
Done
int channel, slotrank, row;
int rowsize;
declare all in one line?
Done
spaces
Done
Patch Set #16, Line 3185: 0x0001f006
please replace with JEDEC macros
Done
(MAX((ctrl->tFAW >> 2) + 1, ctrl->tRRD) << 10)
| 1 | (ctrl->tRCD << 16)
maybe precalculate this?
Ack
Patch Set #16, Line 3190: (slotrank << 24)
This could also be precalculated (to make things fit in one line)
Ack
capital E
Ack
empty line
Done
To view, visit change 22215. To unsubscribe, or for help writing mail filters, visit settings.