Patch Set 15:

This patch was published for the following reasons:

1. Reply to the review:
https://review.coreboot.org/c/coreboot/+/39133/20/src/mainboard/kontron/mal10/gpio.h#50

2. I have been working on converting raw values to macros in GPIO config and
this config for some boards contains pads in which both the Rx and Tx buffers
are enabled.

Please can you help me with this macro?
I'm not sure about this port configuration and I didn’t find any information
about it, except for a few pads from the gpio.h files (see the commit message).
Do you know anything about this? Is this configuration correct for a pad in the
Intel GPIO controller? If not, what should I use instead? GPI or GPO?

Thanks.

Alternative way:

1) add this macro to the local gpio.h for each of the boards;
2) always use bitfield macros and don't convert this to PAD_CFG_*() macro:

_PAD_CFG_STRUCT(GPP_I4,
		PAD_FUNC(GPIO) | PAD_RESET(RSMRST) |
		PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE),
		PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)),

Do you know what the bidir pad is used for on Kontron mal10? If not, Nico or Felix maybe?

View Change

To view, visit change 42914. To unsubscribe, or for help writing mail filters, visit settings.