Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32245 )
Change subject: mediatek: Use the 64-bit timer ......................................................................
Patch Set 6:
Patch Set 5:
Note that this timer is also used in libpayload, so if you change it here, please make sure you also change it there (TIMER_GENERIC_REG and TIMER_GENERIC_HIGH_REG in payloads/libpayload/drivers/timer/Kconfig). Otherwise we may try to use the (then uninitialized) GPT4.
(FWIW we don't generally care about 32-bit roll-over in coreboot, because it doesn't have a use case where it should take anywhere near that long. But I'm fine with fixing this if you want to. In libpayload it's a bit more important because we may sit in recovery mode for a long time.)
Thanks, I've fixed it. Using the uninitialized GPT4, delay(1) will actually wait 2 seconds (but it still boots into kernel).