Patch Set 1:

what OS / payload did you test?
TianoCore CorebootPayload booting Fedora 31.

Last I check this doesn't work for Windows w/Tianocore, but the other Skylake brightness control patch does

Interesting. This patch results in more shared code, but whatever works, I suppose. Do we know what Windows expects in the ACPI table?

I should have been more clear: the current GMA ACPI brightness control don't work for any platform for the Tianocore/Windows pairing. I have an ugly patch in my tree to force Windows to fall back on the vendor driver backlight control (vs ACPI) for pre-SKL platforms. IMO, the whole GMA ACPI setup needs reworking and then we can hook up SKL and newer platforms

View Change

To view, visit change 31503. To unsubscribe, or for help writing mail filters, visit settings.