I think your logic makes sense. We're basically removing vboot_is_slot_selected() and directly reading recovery_reason instead, since we know that a slot will be selected iff a recovery reason is set.

I agree with Julius that we may want to handle all of the vboot_{set,get}_selected_region and vboot_is_slot_selected refactoring in one single CL.

View Change

To view, visit change 36847. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I501110582669ec4f5c1a009f3fd0c0e310083496
Gerrit-Change-Number: 36847
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-Comment-Date: Fri, 15 Nov 2019 11:38:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment