8 comments:
Patch Set #14, Line 17: goal is
goals are
Done
Patch Set #14, Line 17: advertisment
advertis*e*ment
Done
Patch Set #14, Line 18: indepent
independent?
Done
its
Done
Patch Set #14, Line 95: #include <framebuffer_info.h>
At the top with the other includes, please.
Done
Patch Set #14, Line 78: bits_per_pixel = bpp_mask;
I'm not confident about this one. Why not return NULL? If the fields […]
Done.
What's the definition of bits_per_pixel? does it count gaps, too?
Patch Set #14, Line 116: fb_new_framebuffer_info()
Comment slightly out of date
Done
Patch Set #14, Line 131: bits_per_pixel
Needs to be hardcoded to 32 until you fix the FIXME above.
Done
To view, visit change 39002. To unsubscribe, or for help writing mail filters, visit settings.