Patch Set 3:

Have a look at Stage handoff protocol here:
https://doc.coreboot.org/arch/riscv/index.html

a1 contains a pointer to fdt and not to cbmem_top.

That is not the case anymore when calling ramstage, because cbmem_top is put in the program argument. See run_ramstage() in lib/prog_loaders.c. Besides, I'm sure that the stage_entry() function does not properly contain the calling argument that supposedly contains a pointer to the fdt (or cbmem_top in this case) in ramstage.

View Change

To view, visit change 36558. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c74cd5d3ee292931c5bbd2e4075f88381429f72
Gerrit-Change-Number: 36558
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Philipp Hug <philipp@hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-Comment-Date: Sun, 03 Nov 2019 10:51:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment