Patch Set 4:

Please explain why this is needed. The generic PCI driver should already do the same.

1. Without an ACPI name declared, a scope cannot be written to the device.
2. Are you referring to device/pci_device.c? I see that it should call `pci_rom_ssdt`, but it hadn't been successful for me. Possibly due to 1? (or in my case, CB:43070. I'll test again.)

In case the device has no acpi name/scope that's a SoC bug, as it simply doesn't provide those names yet. A console log will show what's missing.

View Change

To view, visit change 43074. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida87aebf8fdf341ab350c2bb3704d2ef695cf8f0
Gerrit-Change-Number: 43074
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jeremy Soller <jeremy@system76.com>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-CC: Prasun Gera
Gerrit-Comment-Date: Fri, 07 Aug 2020 04:38:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment