Patch Set 6:

Patch Set 6: Code-Review-1

"Reserved" in Intel's datasheets means "doesn't concern you"
(which is wrong anyway) but not that the hardware/firmware
doesn't know the bits.

indeed, as they are Reserved, we don't have to mask with 0s .
I mean
Reserved & 1 = Reserved
and
Reserved & 0 = 0
(I agree, it isn't a good dialectic, but vendor uses 0xcf020088)

What does vendor do with that value? Is it what gets written to the CxDRT1 registers?

Patch set 6:Code-Review -1

View Change

To view, visit change 31144. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0cac9160c756405838706edb0461575241faae35
Gerrit-Change-Number: 31144
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 25 Nov 2019 19:19:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment