18 comments:
File src/mainboard/asus/h110m-e_m2/Kconfig:
Patch Set #56, Line 36: config DEVICETREE
No need to re-define the default value, so this config can be removed.
Done
File src/mainboard/asus/h110m-e_m2/acpi_tables.c:
This blank file shouldn't be needed anymore
Done
File src/mainboard/asus/h110m-e_m2/devicetree.cb:
Patch Set #56, Line 203: Enable
done
Done
File src/mainboard/asus/h110m-e_m2/devicetree.cb:
Patch Set #64, Line 204: register "PcieRpClkReqNumber[7]" = "0"
This isn't needed if Clock Request is disabled
File src/mainboard/asus/h110m-e_m2/dsdt.asl:
Patch Set #50, Line 34: // CPU
This comment should be removed, it says nothing useful
*poke*
Patch Set #50, Line 50: // Chipset specific sleep states
This comment should be removed
*poke*
File src/mainboard/asus/h110m-e_m2/dsdt.asl:
now it is there
Done
done
Done
File src/mainboard/asus/h110m-e_m2/dsdt.asl:
Patch Set #64, Line 34: // CPU
This comment should go away.
Patch Set #64, Line 50: // Chipset specific sleep states
This one as well
File src/mainboard/asus/h110m-e_m2/hda_verb.c:
done
Done
File src/mainboard/asus/h110m-e_m2/hda_verb.c:
Um, these ones should also be updated. All the `AZALIA_PIN_CFG(0x0` should just use `0`
2
2
File src/mainboard/asus/h110m-e_m2/romstage.c:
So it doesn't need to be filled at all, I guess?
Ack
Patch Set #50, Line 26: {200, 81, 162}
No schematics for either asus nor asrock desktop boards. […]
LGA1151 CPUs have the RCOMP resistors on the underside of the CPU, and their values are indeed 121, 75 and 100.
Patch Set #50, Line 33: 100, 40, 40, 23, 40
sorry, 2x SO-DIMM was 2x per channel. but I guess your board has only 1 per […]
Done, I guess?
File src/mainboard/asus/h110m-e_m2/romstage.c:
mem_cfg->MemorySpdPtr00 = (uintptr_t)blk.spd_array[0];
mem_cfg->MemorySpdPtr10 = (uintptr_t)blk.spd_array[2];
mem_cfg->MemorySpdPtr01 = (uintptr_t)blk.spd_array[1];
mem_cfg->MemorySpdPtr11 = (uintptr_t)blk.spd_array[3];
some intel board with two DIMMs does exactly that
Done, I guess.
To view, visit change 34603. To unsubscribe, or for help writing mail filters, visit settings.