Attention is currently required from: Matt DeVillier, Angel Pons, Eric Lai.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72765 )
Change subject: soc/intel/rtd3: Hook up supported states to Kconfig
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72765/comment/22c98eea_f642d1d2
PS1, Line 9: S3 does not support D3Cold,
IMHO the power rail of S3 on their board can't support it. D3cold more like the HW support.
Adjusted so it's configurable, but defaults as there are 3 boards in the tree that need it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a4b89132b594ad568a5851137575f921f8e2a2e
Gerrit-Change-Number: 72765
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 09:28:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment