Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
ec/hp/kbc1126: Wait a longer time after sending

This fixes the fan always running at full speed on ProBook 6360b,
EliteBook 8470p and ProBook 640 G1 (because the fan control command was
not sent).

On the ProBook 6360b, the EC needs about 30 ms to process the first
command on a cold boot, but other models such as the ProBook 640 G1 need
more time.

Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Signed-off-by: Pablo Stebler <pablo@stebler.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44750
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M src/ec/hp/kbc1126/ec.c
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ec/hp/kbc1126/ec.c b/src/ec/hp/kbc1126/ec.c
index 5c11fed..8035b94 100644
--- a/src/ec/hp/kbc1126/ec.c
+++ b/src/ec/hp/kbc1126/ec.c
@@ -24,7 +24,7 @@
{
int timeout;

- timeout = 0x7ff;
+ timeout = 100000; /* 1 second */
while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) {
udelay(10);
if ((timeout & 0xff) == 0)
@@ -44,7 +44,7 @@
{
int timeout;

- timeout = 0x7ff;
+ timeout = 100000; /* 1 second */
while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) { /* wait for IBF = 0 */
udelay(10);
if ((timeout & 0xff) == 0)

To view, visit change 44750. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Gerrit-Change-Number: 44750
Gerrit-PatchSet: 11
Gerrit-Owner: Pablo Stebler <pablo@stebler.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Iru Cai (vimacs) <mytbk920423@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged