View Change

10 comments:

• Commit Message:

  • Patch Set #1, Line 7: Apple Mac Mini (mid 2011)

    Rewrite like this:
    mb/apple: Add Mac Mini 5,1 support

    Also add a board number, it looks like 820-????.

  • Patch Set #1, Line 9: tested

    Please add a list of what's been tested, what works and what doesn't.

    Please also add at least a short description of the flashing process, ideally add a page to the documentation.

  • Patch Set #1, Line 11: Mac Mini

    Please use a real name here, patches without a real name cannot be merged.

• File src/mainboard/apple/macmini5_1/Kconfig:

  • Patch Set #1, Line 14:

    # select HAVE_CMOS_DEFAULT
    	# select HAVE_OPTION_TABLE
    

    Should be removed

• File src/mainboard/apple/macmini5_1/devicetree.cb:

  • Patch Set #1, Line 29: ??

    ?

  • Patch Set #1, Line 33: register "docking_supported" = "0"

    this is zero, can be dropped

  • Patch Set #1, Line 38: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"

    can be dropped

  • Patch Set #1, Line 52: device pci 1a.7 on end

    What's this?

  • Patch Set #1, Line 52: device pci 1a.7 on end

    What's this?

• File src/mainboard/apple/macmini5_1/early_init.c:

  • Patch Set #1, Line 10:

    { 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    	{ 1, 0, -1 },
    

    Looks like these are default autoported values? Please fill with correct values if possible. Do you have the schematics for this macmini?

To view, visit change 49074. To unsubscribe, or for help writing mail filters, visit settings.