Sorry, I completely forgot about this review. If it ever
happens again, feel free to ping me on irc.
9 comments:
Patch Set #14, Line 11: splitted
split
File src/drivers/apple/hybrid_graphics/acpi/gmux.asl:
This file is very confusing. What does it do?
Patch Set #14, Line 30: Name (_PRW, Package (0x02) { 0x16, 0x03 })
Needs `gpi6_routing` in devicetree?
NB. I don't quite understand why this would generate a wake event?
Patch Set #14, Line 33: Method (_L16, 0, NotSerialized)
see above
Patch Set #14, Line 44: \GP06 |= Arg0
`|= 0` seems like a no-op???
Also, I'm confused. Is it an input or output? Should it be switched
to input maybe during sleep?
File src/drivers/apple/hybrid_graphics/gmux.h:
Patch Set #8, Line 45: int port
you're right.
Ack
File src/drivers/apple/hybrid_graphics/gmux.c:
Patch Set #8, Line 34: udelay(100);
Well, what you're saying seems logical, but this code is from apple-gmux linux driver. […]
Understood.
Patch Set #8, Line 38: return !!i;
Shouldn't this be `!(gwr & 0x01)`? i.e. […]
This however looks like a bug in the code flow and is not
related to the hardware interface.
File src/drivers/apple/hybrid_graphics/romstage.c:
Patch Set #8, Line 30: /* TODO: Use generic device instead of dummy PNP device */
It's based on lenovo/hybrid_graphics. […]
I would simply try `device generic` in the dt and find_dev_path()
here. Maybe I think it's too easy, no idea what could go wrong.
To view, visit change 32719. To unsubscribe, or for help writing mail filters, visit settings.