build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45472 ) Change subject: cpu/x86/smm: Add save state ops for different save states ...................................................................... Patch Set 3: (8 comments) https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/amd/smm/amd64_save_... File src/cpu/amd/smm/amd64_save_state.c: https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/amd/smm/amd64_save_... PS3, Line 57: static int amd64_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/intel/smm/em64t100_... File src/cpu/intel/smm/em64t100_save_state.c: https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/intel/smm/em64t100_... PS3, Line 58: static int em64t100_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/intel/smm/em64t100_... PS3, Line 63: static int em64t100_set_reg(const enum cpu_reg reg, const int node, void *in, const uint8_t length) line over 96 characters https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/intel/smm/em64t101_... File src/cpu/intel/smm/em64t101_save_state.c: https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/intel/smm/em64t101_... PS3, Line 10: const em64t101_smm_state_save_area_t *save_state = (const em64t101_smm_state_save_area_t *)smm_get_save_state(node); line over 96 characters https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/intel/smm/em64t101_... PS3, Line 57: static int em64t101_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/intel/smm/em64t101_... PS3, Line 62: static int em64t101_set_reg(const enum cpu_reg reg, const int node, void *in, const uint8_t length) line over 96 characters https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/x86/smm/legacy_save... File src/cpu/x86/smm/legacy_save_state.c: https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/x86/smm/legacy_save... PS3, Line 57: static int legacy_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters https://review.coreboot.org/c/coreboot/+/45472/3/src/cpu/x86/smm/legacy_save... PS3, Line 62: static int legacy_set_reg(const enum cpu_reg reg, const int node, void *in, const uint8_t length) line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/45472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67ab44fbdca5fac5837d32ffda5caad61e534473 Gerrit-Change-Number: 45472 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 29 Sep 2020 09:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment