8 comments:
File src/mainboard/apple/macbookpro8_1/acpi_tables.c:
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
These can be dropped, as they are zero already.
Done
File src/mainboard/apple/macbookpro8_1/devicetree.cb:
These can be simply zero
Done
This one as well
Done
Patch Set #11, Line 37: subsystemid 0x106b 0x00db
If it's off, does it need a subsystemid?
Done
Patch Set #11, Line 60: Audio Audio
Is it stereo audio? I would shorten this as "HD Audio Controller"
Of course it's stereo!
File src/mainboard/apple/macbookpro8_1/dsdt.asl:
#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB
#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB
#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Are you using these?
Done
File src/mainboard/apple/macbookpro8_1/early_init.c:
Are you using all these headers?
Done
File src/mainboard/apple/macbookpro8_1/mainboard.c:
RCBA32(0x38c8) = 0x00002005;
RCBA32(0x38c4) = 0x00800000;
Aren't these doing the same as the VSCC settings in the devicetree?
You're right.
To view, visit change 33151. To unsubscribe, or for help writing mail filters, visit settings.