/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
These can be dropped, as they are zero already.
These can be simply zero
This one as well
Patch Set #11, Line 37:
subsystemid 0x106b 0x00db
If it's off, does it need a subsystemid?
Patch Set #11, Line 60:
Is it stereo audio? I would shorten this as "HD Audio Controller"
Of course it's stereo!
#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB
#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB
#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Are you using these?
Are you using all these headers?
RCBA32(0x38c8) = 0x00002005;
RCBA32(0x38c4) = 0x00800000;
Aren't these doing the same as the VSCC settings in the devicetree?
To view, visit change 33151. To unsubscribe, or for help writing mail filters, visit settings.