Attention is currently required from: Erik van den Bogaert, Felix Singer, Frans Hendriks, Jonathon Hall, Michał Żygowski, Nico Huber, Piotr Król.
View Change
1 comment:
Patchset:
Patch Set #6:
You also forget about cases where we currently have an `on`
without matching FSP setting. These need to be turned `off`.
That's also manual work.
That needs to be done anyway, no?
I like automation and gettings things done in a reproducible way. Also, I agree that review is *way* easier when the values needing comparison are located next to each other. However, I see the problems in this specific case.
What about only moving the Fsp settings above the device entries? This is less manual work in this patch (no need to adapt comments, line breaks) but still makes review easier.
Example:
```
-register "PcieRpEnable[0]" = "1"
-register "PcieRpEnable[3]" = "1"
...
+register "PcieRpEnable[0]" = "1"
device ref pcie_rp3 on end # Ethernet controller
+register "PcieRpEnable[3]" = "1"
device ref pcie_rp4 on
# Whatever controller
register xyz = 1
register abc = 2
end
```
To view, visit change 79958. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I397497118d6868e4a6d4086e97901081da7d5fda
Gerrit-Change-Number: 79958
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jan Samek <jan.samek@siemens.com>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Erik van den Bogaert <ebogaert@eltan.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Attention: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 07:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment