Patch Set 14: Code-Review+1

I tend to agree that spi probably does not belong in the function name.

Right I did probably cut spi_lock_bar in two when creating the function ... that would explain the (bad) name.
It should probably be lpc_ or pch_.


Note that I no longer work at scaleway and didn't found enough free time to setup a build environment yet.

Best Regards,
Julien VdG

View Change

To view, visit change 25442. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic028ae9920e932dfe67fdfc0c6f1f53377a158cd
Gerrit-Change-Number: 25442
Gerrit-PatchSet: 14
Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju@vdg.name>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju@vdg.name>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Steve Mooney
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jay Talbott <JayTalbott@sysproconsulting.com>
Gerrit-CC: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-Comment-Date: Mon, 01 Jul 2019 11:33:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment