Patch set 1:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 7: Documentation: Some notes about how to integrate FSP

    Nit: Please add verb: Add some notes …

• File Documentation/soc/intel/fsp/index.md:

  • Patch Set #1, Line 8: has an effect on

    affects

  • Patch Set #1, Line 11:

    * It should be possible to replace FSP based boot with a native
      coreboot implementation for a given chipset without touching the
      mainboard code.
    * The devicetree configures coreboot and part of what coreboot does
      with the information is setting some FSP UPDs. The devicetree isn't
      supposed to directly configure FSP.
    

    Reflow for full textwidth?

To view, visit change 58886. To unsubscribe, or for help writing mail filters, visit settings.