[coreboot-gerrit] [XS] Change in coreboot[master]: mb/siemens/mc_apl1: Fix wrong register masking

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76177?usp=email )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: mb/siemens/mc_apl1: Fix wrong register masking
......................................................................

mb/siemens/mc_apl1: Fix wrong register masking

With the previous instruction the complete register was set to '0'.
Correctly, only the bits 23:16 must be masked.

Change-Id: Idd6e70dcb42c69cf3bc5d36db993e6def52eba58
Signed-off-by: Mario Scheithauer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76177
Reviewed-by: Eric Lai 
Reviewed-by: Felix Singer 
Tested-by: build bot (Jenkins) 
Reviewed-by: Jan Samek 
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jan Samek: Looks good to me, approved
  Eric Lai: Looks good to me, approved
  Felix Singer: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
index b7b997b..8490ddc 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
@@ -12,6 +12,7 @@
 #include <types.h>

#define TX_DWORD3_P1	0xa8c
+#define TX_SWING_MASK	0x00ff0000

void variant_mainboard_final(void)
 {
@@ -42,10 +43,10 @@
    /*
     * Correct the SATA transmit signal via the High Speed I/O Transmit
     * Control Register 3 on SATA port 1.
-	 * Bit [23:16] set the output voltage swing for TX line.
+	 * Bit [23:16] sets the output voltage swing for TX line.
     * The value 0x4a sets the swing level to 0.58 V.
     */
-	pcr_rmw32(PID_MODPHY, TX_DWORD3_P1, (0x00 << 16), (0x4a << 16));
+	pcr_rmw32(PID_MODPHY, TX_DWORD3_P1, ~TX_SWING_MASK, 0x4a << 16);
 }

static void finalize_boot(void *unused)