Patch Set 2: Code-Review-1

Other programs including coreboot itself rely on "config" and "revision" without a prefix.

I have checked access to CBFS from the following APIs:

soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
commonlib/cbfs.c
lib/cbfs.c cbfs.*load.*()

but did not find any uses of "config" or "revision". I could argue that only one of fallback or normal gets these files, and that therefore the other could get a prefix, but I would rather understand any consumers of these files from CBFS to see if this proposal still makes sense.

Can anyone point me to consumers of these files?

View Change

To view, visit change 42028. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e904e44137f731f239f51dbf224965f33838e19
Gerrit-Change-Number: 42028
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Jackson <jerj@coplanar.net>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 05 Jun 2020 01:42:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment