Attention is currently required from: Patrick Georgi, Furquan Shaikh, Vitaly Rodionov, Marco Chen, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 )
Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61448/comment/47ffb3f8_8212b9b8
PS2, Line 9: This driver uses the ACPI Device Property interface to generate
Mention the full chip vendor and name here?
Patchset:
PS2:
Thanks you Vitaly, this is a very well-documented driver! Just a few minor nits
File src/drivers/i2c/cs35l53/cs35l53.c:
https://review.coreboot.org/c/coreboot/+/61448/comment/0c4c93c4_6cf1a0a7
PS2, Line 56: AAD
`Add`
?
https://review.coreboot.org/c/coreboot/+/61448/comment/3e37256f_82cc95d3
PS2, Line 105: 5
nit:
`ACPI_NAME_BUFFER_SIZE`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606
Gerrit-Change-Number: 61448
Gerrit-PatchSet: 2
Gerrit-Owner: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Vitaly Rodionov
vitaly.rodionov@cirrus.corp-partner.google.com
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 04 Feb 2022 22:03:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment