Kyösti Mälkki submitted this change.

View Change

Approvals: build bot (Jenkins): Verified ron minnich: Looks good to me, approved
mb/: Drop the provided name in chip_ops

Little point to replicate a string already provided both
as a global Kconfig and global mainboard_part_number.

Change-Id: I1fd138c711ebbb37c39b2c8f554b1f2e1a364424
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50719
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: ron minnich <rminnich@gmail.com>
---
M src/mainboard/cavium/cn8100_sff_evb/mainboard.c
M src/mainboard/emulation/qemu-aarch64/mainboard.c
M src/mainboard/google/asurada/mainboard.c
M src/mainboard/google/foster/mainboard.c
M src/mainboard/google/gale/mainboard.c
M src/mainboard/google/gru/mainboard.c
M src/mainboard/google/kukui/mainboard.c
M src/mainboard/google/mistral/mainboard.c
M src/mainboard/google/nyan/mainboard.c
M src/mainboard/google/nyan_big/mainboard.c
M src/mainboard/google/nyan_blaze/mainboard.c
M src/mainboard/google/oak/mainboard.c
M src/mainboard/google/peach_pit/mainboard.c
M src/mainboard/google/smaug/mainboard.c
M src/mainboard/google/storm/mainboard.c
M src/mainboard/google/trogdor/mainboard.c
M src/mainboard/opencellular/elgon/mainboard.c
M src/mainboard/sifive/hifive-unleashed/mainboard.c
18 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/src/mainboard/cavium/cn8100_sff_evb/mainboard.c b/src/mainboard/cavium/cn8100_sff_evb/mainboard.c
index 3b26722..8c25b1e 100644
--- a/src/mainboard/cavium/cn8100_sff_evb/mainboard.c
+++ b/src/mainboard/cavium/cn8100_sff_evb/mainboard.c
@@ -261,6 +261,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/emulation/qemu-aarch64/mainboard.c b/src/mainboard/emulation/qemu-aarch64/mainboard.c
index 212064b..988502f 100644
--- a/src/mainboard/emulation/qemu-aarch64/mainboard.c
+++ b/src/mainboard/emulation/qemu-aarch64/mainboard.c
@@ -17,7 +17,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "qemu_aarch64",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/asurada/mainboard.c b/src/mainboard/google/asurada/mainboard.c
index 812cb00..16325c8 100644
--- a/src/mainboard/google/asurada/mainboard.c
+++ b/src/mainboard/google/asurada/mainboard.c
@@ -232,6 +232,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/foster/mainboard.c b/src/mainboard/google/foster/mainboard.c
index 4a56e8a..7c34756 100644
--- a/src/mainboard/google/foster/mainboard.c
+++ b/src/mainboard/google/foster/mainboard.c
@@ -103,6 +103,5 @@
}

struct chip_operations mainboard_ops = {
- .name = "foster",
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/gale/mainboard.c b/src/mainboard/google/gale/mainboard.c
index bc4fc93..3c4f861 100644
--- a/src/mainboard/google/gale/mainboard.c
+++ b/src/mainboard/google/gale/mainboard.c
@@ -49,7 +49,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "gale",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c
index 2bf7854..1690fb2 100644
--- a/src/mainboard/google/gru/mainboard.c
+++ b/src/mainboard/google/gru/mainboard.c
@@ -684,6 +684,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c
index 7efa01b..fbdf633 100644
--- a/src/mainboard/google/kukui/mainboard.c
+++ b/src/mainboard/google/kukui/mainboard.c
@@ -219,6 +219,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/mistral/mainboard.c b/src/mainboard/google/mistral/mainboard.c
index 4079182..804afb4 100644
--- a/src/mainboard/google/mistral/mainboard.c
+++ b/src/mainboard/google/mistral/mainboard.c
@@ -32,6 +32,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/nyan/mainboard.c b/src/mainboard/google/nyan/mainboard.c
index 5b7e02c..8bce1b2 100644
--- a/src/mainboard/google/nyan/mainboard.c
+++ b/src/mainboard/google/nyan/mainboard.c
@@ -236,7 +236,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "nyan",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/nyan_big/mainboard.c b/src/mainboard/google/nyan_big/mainboard.c
index 335688a..81da912 100644
--- a/src/mainboard/google/nyan_big/mainboard.c
+++ b/src/mainboard/google/nyan_big/mainboard.c
@@ -234,7 +234,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "nyan_big",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/nyan_blaze/mainboard.c b/src/mainboard/google/nyan_blaze/mainboard.c
index 79ee657..4499f9c 100644
--- a/src/mainboard/google/nyan_blaze/mainboard.c
+++ b/src/mainboard/google/nyan_blaze/mainboard.c
@@ -234,7 +234,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "nyan_blaze",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/oak/mainboard.c b/src/mainboard/google/oak/mainboard.c
index cd17ede..0e9dc13 100644
--- a/src/mainboard/google/oak/mainboard.c
+++ b/src/mainboard/google/oak/mainboard.c
@@ -264,6 +264,5 @@
}

struct chip_operations mainboard_ops = {
- .name = "oak",
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/google/peach_pit/mainboard.c b/src/mainboard/google/peach_pit/mainboard.c
index ab3c0f5..c279777 100644
--- a/src/mainboard/google/peach_pit/mainboard.c
+++ b/src/mainboard/google/peach_pit/mainboard.c
@@ -452,7 +452,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "peach_pit",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/smaug/mainboard.c b/src/mainboard/google/smaug/mainboard.c
index 852e73d..fe09d32 100644
--- a/src/mainboard/google/smaug/mainboard.c
+++ b/src/mainboard/google/smaug/mainboard.c
@@ -197,7 +197,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "smaug",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/storm/mainboard.c b/src/mainboard/google/storm/mainboard.c
index 4faf832..aff7b94f 100644
--- a/src/mainboard/google/storm/mainboard.c
+++ b/src/mainboard/google/storm/mainboard.c
@@ -95,7 +95,6 @@
}

struct chip_operations mainboard_ops = {
- .name = "storm",
.enable_dev = mainboard_enable,
};

diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c
index 9bf8507..61a64f8 100644
--- a/src/mainboard/google/trogdor/mainboard.c
+++ b/src/mainboard/google/trogdor/mainboard.c
@@ -127,6 +127,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/opencellular/elgon/mainboard.c b/src/mainboard/opencellular/elgon/mainboard.c
index f9dc03c..c935d2b 100644
--- a/src/mainboard/opencellular/elgon/mainboard.c
+++ b/src/mainboard/opencellular/elgon/mainboard.c
@@ -104,6 +104,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};
diff --git a/src/mainboard/sifive/hifive-unleashed/mainboard.c b/src/mainboard/sifive/hifive-unleashed/mainboard.c
index e0b4305..22bd9fa 100644
--- a/src/mainboard/sifive/hifive-unleashed/mainboard.c
+++ b/src/mainboard/sifive/hifive-unleashed/mainboard.c
@@ -10,6 +10,5 @@
}

struct chip_operations mainboard_ops = {
- .name = CONFIG_MAINBOARD_PART_NUMBER,
.enable_dev = mainboard_enable,
};

To view, visit change 50719. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fd138c711ebbb37c39b2c8f554b1f2e1a364424
Gerrit-Change-Number: 50719
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp@hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-MessageType: merged