[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC

[Martin L Roth (Code Review)]

Attention is currently required from: David Wu, Tarun Tuli, Nick Vaccaro.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71628 )

Change subject: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC
......................................................................

Patch Set 1:

(1 comment)

File src/mainboard/google/brya/variants/kano/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/71628/comment/b781b62f_70778936 
PS1, Line 20: 		option UFC_MIPI_OVTI2740        0
> You can use ec command (ectool cbi get 8) to get the SSFC data to know whether or not to use SSFC. […]

I still don't understand why UFC_MIPI_HI556 can't just be value 3 in the UFC field, and why the SSFC fields can't just be used to extend the UFC field if more bits are needed.  It seems very odd that we'd need a completely new field here, with one of the options being the same as one of the options in the existing field.

I'm not objecting - but it seems strange that this is needed at all.

I think that being able to extend the existing fields using the SSFC is kind of the point of SSFC returning 0 instead of an error when it's not initialized.