Attention is currently required from: Sean Rhodes, Stefan Reinauer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65922 )
Change subject: payloads/edk2: Add a recipe for UniversalPayload.elf
......................................................................
Patch Set 34:
(1 comment)
File payloads/external/edk2/Makefile:
https://review.coreboot.org/c/coreboot/+/65922/comment/43eb84b6_ed4bd62e
PS34, Line 231: $(payload_entry) \
: $(WORKSPACE)/Build/UefiPayloadPkgX64/$(RELEASE_STR)_COREBOOT/FV/DXEFV.Fv \
: $(WORKSPACE)/Build/UniversalPayloadInfo.bin \
: print
Nit: Indent an extra level. Right now it's hard to tell the difference between the rrereqs and the actual target build info.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idff6b18392fd41c8766341c7933441b6b9ff6edf
Gerrit-Change-Number: 65922
Gerrit-PatchSet: 34
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 04 Sep 2022 16:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
