View Change
1 comment:
Commit Message:
Patch Set #11, Line 17:
don't need to
be aligned, add a '%' after section
First time I glanced over the CL I thought "okay, % as in '% blocksize == 0', so that marks alignment"
That is PS9
but it means the opposite. Maybe give it a name instead of a symbol?
That was discussed in PS8 before I upload Ps9 :)
"unaligned" would make the point clear, and it could fit in the existing syntax: COREBOOT(CBFS,UNALIGNED)
That is PS1, although it was 'ALIGNED' at that time :)
To view, visit change 37262. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9
Gerrit-Change-Number: 37262
Gerrit-PatchSet: 11
Gerrit-Owner: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Patrick Georgi <pgeorgi@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 04 Dec 2019 03:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: comment