Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35174 )
Change subject: mb/google/poppy/variant/nocturne: add EC_SYNC_GPIO ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35174/2/src/mainboard/google/poppy/... File src/mainboard/google/poppy/chromeos.c:
https://review.coreboot.org/c/coreboot/+/35174/2/src/mainboard/google/poppy/... PS2, Line 36: EC_SYNC_IRQ
GPIO#
Done
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... File src/mainboard/google/poppy/chromeos.c:
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... PS5, Line 35: CONFIG(BOARD_GOOGLE_NOCTURNE)
Good idea.
Done
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... PS5, Line 199: PAD_CFG_GPI_APIC_INVERT
It does not make a difference for the functionality in depthcharge. […]
Done
https://review.coreboot.org/c/coreboot/+/35174/2/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35174/2/src/mainboard/google/poppy/... PS2, Line 38: GPP_D17_IRQ
EC_ENABLE_SYNC_IRQ is not set for nocturne. Should it be? […]
Done