3 comments:
File src/mainboard/google/kukui/romstage.c:
Patch Set #7, Line 32: pmic_set_vsim2_cali();
There should be a short code comment here why this is necessary, e.g.
/* Adjust VSIM2 down to 2.7V because it is shared with IT6505. */
File src/soc/mediatek/mt8183/include/soc/mt6358.h:
Patch Set #7, Line 42: void pmic_set_vsim2_cali(void);
Hi Julius, […]
I guess the hardcoding of 0.06 still feels a bit weird? Maybe this should be pmic_adjust_vsim2_cali(int millivolts), and then you can call it with -60 for Kukui. Or maybe pmic_set_vsim2(2700).
File src/soc/mediatek/mt8183/mt6358.c:
Patch Set #10, Line 745: vsim2_cali_0mv = (vsim2_cali_0mv > 6) ? (vsim2_cali_0mv - 6) : 0;
nit: I think writing this as
vsim2_cali_0mv = MIN(vsim2_cali_0mv - 6, 0);
would be more readable.
To view, visit change 32057. To unsubscribe, or for help writing mail filters, visit settings.