View Change

12 comments:

• File 3rdparty/blobs:

  • Patch Set #14, Line 1:

    we should not delete 3rdparty/blob library. please revert this.

• File src/soc/mediatek/mt8183/dsi.c:

  • Patch Set #14, Line 23: static

    any reason to declare dsi_write32 here, instead of simply using write32?

    if really needed, I think this can be 'static inline'.

  • Patch Set #14, Line 48: int

    the printf said data_rate is unsigned int.

  • Patch Set #14, Line 65: (u64)(edid->mode.pixel_clock * 1000 * bpp) / lanes;

    we should cast to larger types in the beginning, i.e:

    (u64)edid->mode.pixel_clock * 1000 * bpp / lanes;

  • Patch Set #14, Line 103: (u64)

    u64 should be converted earlier, whenever the value will exceed 32 bits.

  • Patch Set #14, Line 110: 30

    Add a comment for what we're waiting for?

  • Patch Set #14, Line 115: 40

    any comment for why 40?

  • Patch Set #14, Line 298: "HFP less than d-phy, FPS will under 60Hz\n");

    exceed col 80

  • Patch Set #14, Line 305: "HFP less than d-phy, FPS will under 60Hz\n");

    exceed col 80

  • Patch Set #14, Line 377: (void *)DSI_BASE + 0x200 + i

    (void *)(DSI_BASE + 0x200 + i)

    In fact you should make it clear what's that 200 for. maybe something like

    uintptr_t dsi_something = DSI_BASE + 0x200;

  • Patch Set #14, Line 395: 4

    add a comment for why 4

• File src/soc/mediatek/mt8183/include/soc/dsi.h:

  • Patch Set #14, Line 476: MTK_DSI_HOST_IS_READ

    I'm not seeing a strong reason to put this as macro here, bcz it's only called one time.

    Maybe move this back into c source, or change to an inline function.

To view, visit change 31591. To unsubscribe, or for help writing mail filters, visit settings.