Attention is currently required from: Alexander Couzens, Evgeny Zinoviev.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83860?usp=email )
Change subject: i945: Use nullptr instead of NULL
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83860/comment/375da0f5_c1e03c33?usp... :
PS4, Line 7: [Prepare for C23]
I'd probably remove the C23 text since it doesn't seem to be completely accurate. […]
Done
https://review.coreboot.org/c/coreboot/+/83860/comment/da97b22f_a88e9510?usp... :
PS4, Line 10:
Maybe mention that nullptr was introduced in C11 spec and gcc 4.7. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83860?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7d47e692a33d739345a81f589d4329a31beeb8c5
Gerrit-Change-Number: 83860
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 28 Sep 2024 08:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com