Matt DeVillier has uploaded this change for review.

View Change

mb/google/hatch (baseboard): add ACPI backlight support

Add ACPI backlight support for boards selecting BOARD_GOOGLE_BASEBOARD_HATCH.
PUFF-based variants do not have an attached display, so do not need this.

Test: build/boot Windows 10 20H2 on google/akemi, verify
display backlight controls functional.

Change-Id: I5ce4c6e1c78299e89760a1356da452d56ba0aee6
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
---
M src/mainboard/google/hatch/dsdt.asl
M src/mainboard/google/hatch/variants/akemi/overridetree.cb
M src/mainboard/google/hatch/variants/dratini/overridetree.cb
M src/mainboard/google/hatch/variants/hatch/overridetree.cb
M src/mainboard/google/hatch/variants/helios/overridetree.cb
M src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb
M src/mainboard/google/hatch/variants/jinlon/overridetree.cb
M src/mainboard/google/hatch/variants/kindred/overridetree.cb
M src/mainboard/google/hatch/variants/kohaku/overridetree.cb
M src/mainboard/google/hatch/variants/mushu/overridetree.cb
M src/mainboard/google/hatch/variants/nightfury/overridetree.cb
M src/mainboard/google/hatch/variants/palkia/overridetree.cb
M src/mainboard/google/hatch/variants/stryke/overridetree.cb
13 files changed, 39 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/49058/1
diff --git a/src/mainboard/google/hatch/dsdt.asl b/src/mainboard/google/hatch/dsdt.asl
index 1395c8f..d668440 100644
--- a/src/mainboard/google/hatch/dsdt.asl
+++ b/src/mainboard/google/hatch/dsdt.asl
@@ -26,6 +26,9 @@
{
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
#include <soc/intel/cannonlake/acpi/southbridge.asl>
+#if CONFIG(BOARD_GOOGLE_BASEBOARD_HATCH)
+ #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
+#endif
}
}

diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb
index 8ae350c..97a6eaf 100644
--- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb
@@ -72,6 +72,9 @@
register "ScsEmmcHs400Enabled" = "1"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
register "desc" = ""Root Hub""
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
index 3b094a3..3605196 100644
--- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
@@ -69,6 +69,9 @@
register "ScsEmmcHs400Enabled" = "1"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
device usb 0.0 on
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
index e13270f..01afa16 100644
--- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
@@ -68,6 +68,9 @@
register "sdcard_cd_gpio" = "vSD3_CD_B"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 15.0 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb
index 4241a46..c935620 100644
--- a/src/mainboard/google/hatch/variants/helios/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb
@@ -60,6 +60,9 @@
}"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
device usb 0.0 on
diff --git a/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb b/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb
index 6fbe950..129bb26 100644
--- a/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/helios_diskswap/overridetree.cb
@@ -76,6 +76,9 @@
}"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
device usb 0.0 on
diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb
index 750e068..16402af 100644
--- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb
@@ -69,6 +69,9 @@
register "ScsEmmcHs400Enabled" = "1"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 02.0 on
chip drivers/gfx/generic
register "device_count" = "1"
diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb
index c06f35b..f27423f 100644
--- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb
@@ -105,6 +105,9 @@
register "common_soc_config.emmc_dll.emmc_rx_strobe_cntl" = "0x1515"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 15.0 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
index 740a7d8..266346b 100644
--- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
@@ -73,6 +73,9 @@
}"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
device usb 0.0 on
diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb
index 29b87e4..74b3e1f 100644
--- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb
@@ -88,6 +88,9 @@
register "sdcard_cd_gpio" = "vSD3_CD_B"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 15.0 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
diff --git a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
index ff61d80..8805a32 100644
--- a/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/nightfury/overridetree.cb
@@ -121,6 +121,9 @@
register "common_soc_config.emmc_dll.emmc_rx_strobe_cntl" = "0x1515"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
device usb 0.0 on
diff --git a/src/mainboard/google/hatch/variants/palkia/overridetree.cb b/src/mainboard/google/hatch/variants/palkia/overridetree.cb
index 8cdb2a9..b7f6ff2 100644
--- a/src/mainboard/google/hatch/variants/palkia/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/palkia/overridetree.cb
@@ -57,6 +57,9 @@
}"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
device usb 0.0 on
diff --git a/src/mainboard/google/hatch/variants/stryke/overridetree.cb b/src/mainboard/google/hatch/variants/stryke/overridetree.cb
index 3611e58..aa73ab6 100644
--- a/src/mainboard/google/hatch/variants/stryke/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/stryke/overridetree.cb
@@ -58,6 +58,9 @@
register "sdcard_cd_gpio" = "vSD3_CD_B"

device domain 0 on
+ device pci 02.0 on # Integrated Graphics Device
+ register "gfx" = "GMA_DEFAULT_PANEL(0)"
+ end
device pci 14.0 on
chip drivers/usb/acpi
register "desc" = ""Root Hub""

To view, visit change 49058. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ce4c6e1c78299e89760a1356da452d56ba0aee6
Gerrit-Change-Number: 49058
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-MessageType: newchange