So if you can address these comments, and we can work out why this won't build, we can get this in soon I hope.
7 comments:
File src/security/intel/stm/SmmStm.h:
Patch Set #21, Line 43: * @retval OUT_OF_RESOURCES If nested procedure returned it and we cannot
I think you need a space here.
Patch Set #21, Line 77: * This function notify STM resource change.
Notify and STM resource change
Patch Set #21, Line 84: * This function return BIOS STM resource.
Get a BIOS STM resource
File src/security/intel/stm/SmmStm.c:
Patch Set #21, Line 295: UINTN index;
it would be nice to use uintptr_t instead of UINTN. I realize Intel likes it but ... uintptr_t is a bit more standard.
File src/security/intel/stm/StmApi.h:
Patch Set #21, Line 26: typedef uint64_t UINTN;
oh boy. We have 22 different typedefs of UINTN in the coreboot tree today. In some code Intel makes this a uintptr_t, and here it looks like it's a uint64_t. Could we just replace all uses of UINTN with uint64_t in the STM code so people don't have to dig around? Otherwise it gets confusing.
Patch Set #21, Line 60: uint32_t stm_smm_rev_id[1];
BY this did they mean an array of one uint32_t or an indeterminate length array? If the latter this is a pre-gcc 3.0 usage. If the former, why an array?
Patch Set #21, Line 83: uint64_t image_page_base[1]; //[NumberOfPages];
why 1 ...
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.