Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved David Guckian: Looks good to me, but someone else must approve
src: include <assert.h> when appropriate

Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/26796
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: David Guckian
---
M src/arch/arm64/arm_tf.c
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/commonlib/storage/pci_sdhci.c
M src/commonlib/storage/sd.c
M src/commonlib/storage/sd_mmc.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
M src/commonlib/storage/storage.c
M src/cpu/intel/hyperthreading/intel_sibling.c
M src/cpu/intel/model_206ax/model_206ax_init.c
M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
M src/drivers/spi/winbond.c
M src/lib/gpio.c
M src/mainboard/google/dragonegg/romstage_fsp_params.c
M src/mainboard/intel/galileo/vboot.c
M src/northbridge/amd/pi/00630F01/northbridge.c
M src/security/vboot/vbnv_flash.c
M src/soc/cavium/cn81xx/ecam0.c
M src/soc/cavium/cn81xx/twsi.c
M src/soc/cavium/common/ecam.c
M src/soc/intel/apollolake/acpi.c
M src/soc/intel/apollolake/gpio_apl.c
M src/soc/intel/apollolake/gpio_glk.c
M src/soc/intel/apollolake/uart.c
M src/soc/intel/cannonlake/romstage/romstage.c
M src/soc/intel/cannonlake/uart.c
M src/soc/intel/common/block/sgx/sgx.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/denverton_ns/gpio.c
M src/soc/intel/icelake/romstage/romstage.c
M src/soc/intel/icelake/uart.c
M src/soc/intel/quark/spi.c
M src/soc/intel/skylake/cpu.c
M src/soc/intel/skylake/gpio.c
M src/soc/mediatek/common/include/soc/rtc_common.h
M src/soc/mediatek/common/pmic_wrap.c
M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
M src/soc/mediatek/mt8173/emi.c
M src/soc/mediatek/mt8173/pmic_wrap.c
M src/soc/mediatek/mt8183/mt6358.c
M src/soc/qualcomm/ipq40xx/i2c.c
M src/soc/qualcomm/ipq806x/i2c.c
M src/soc/rockchip/common/edp.c
M src/soc/rockchip/common/pwm.c
M src/soc/rockchip/rk3288/hdmi.c
M src/soc/rockchip/rk3288/tsadc.c
M src/soc/rockchip/rk3399/bl31_plat_params.c
M src/soc/rockchip/rk3399/mipi.c
M src/soc/rockchip/rk3399/tsadc.c
M src/soc/samsung/exynos5250/alternate_cbfs.c
M src/soc/samsung/exynos5250/pinmux.c
M src/soc/samsung/exynos5420/alternate_cbfs.c
M src/soc/samsung/exynos5420/pinmux.c
M src/superio/renesas/m3885x/superio.c
M src/superio/smsc/lpc47n227/early_serial.c
56 files changed, 4 insertions(+), 53 deletions(-)

diff --git a/src/arch/arm64/arm_tf.c b/src/arch/arm64/arm_tf.c
index f43bc02..291e4ee 100644
--- a/src/arch/arm64/arm_tf.c
+++ b/src/arch/arm64/arm_tf.c
@@ -18,7 +18,6 @@
#include <arch/mmu.h>
#include <arch/transition.h>
#include <arm_tf.h>
-#include <assert.h>
#include <bootmem.h>
#include <cbfs.h>
#include <console/console.h>
diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index 3f9f994..e283f4d 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -28,6 +28,7 @@
#include <lib.h>
#include <string.h>
#include <arch/acpigen.h>
+#include <assert.h>
#include <console/console.h>
#include <device/device.h>

diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h
index 9e57693..6114667 100644
--- a/src/arch/x86/include/arch/acpigen.h
+++ b/src/arch/x86/include/arch/acpigen.h
@@ -18,7 +18,6 @@
#ifndef LIBACPI_H
#define LIBACPI_H

-#include <assert.h>
#include <stdlib.h>
#include <stdint.h>
#include <arch/acpi.h>
diff --git a/src/commonlib/storage/pci_sdhci.c b/src/commonlib/storage/pci_sdhci.c
index a2d3094..1798c2c 100644
--- a/src/commonlib/storage/pci_sdhci.c
+++ b/src/commonlib/storage/pci_sdhci.c
@@ -18,7 +18,6 @@
#endif

#include <arch/early_variables.h>
-#include <assert.h>
#include <commonlib/sdhci.h>
#include <device/pci.h>
#include <device/pci_ops.h>
diff --git a/src/commonlib/storage/sd.c b/src/commonlib/storage/sd.c
index 2e1ae85..06f0156 100644
--- a/src/commonlib/storage/sd.c
+++ b/src/commonlib/storage/sd.c
@@ -19,7 +19,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <commonlib/sd_mmc_ctrlr.h>
#include <commonlib/storage.h>
#include <delay.h>
diff --git a/src/commonlib/storage/sd_mmc.c b/src/commonlib/storage/sd_mmc.c
index fd59bd0..348d3fe 100644
--- a/src/commonlib/storage/sd_mmc.c
+++ b/src/commonlib/storage/sd_mmc.c
@@ -20,7 +20,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <commonlib/storage.h>
#include <delay.h>
#include <endian.h>
diff --git a/src/commonlib/storage/sdhci.c b/src/commonlib/storage/sdhci.c
index 5c85e99..19daa2e 100644
--- a/src/commonlib/storage/sdhci.c
+++ b/src/commonlib/storage/sdhci.c
@@ -17,7 +17,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include "bouncebuf.h"
#include <commonlib/sd_mmc_ctrlr.h>
#include <commonlib/sdhci.h>
diff --git a/src/commonlib/storage/sdhci_adma.c b/src/commonlib/storage/sdhci_adma.c
index bf6f457..e320973 100644
--- a/src/commonlib/storage/sdhci_adma.c
+++ b/src/commonlib/storage/sdhci_adma.c
@@ -17,7 +17,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <commonlib/sdhci.h>
#include <commonlib/storage.h>
#include <console/console.h>
diff --git a/src/commonlib/storage/storage.c b/src/commonlib/storage/storage.c
index d8ff4bc..f434a6c 100644
--- a/src/commonlib/storage/storage.c
+++ b/src/commonlib/storage/storage.c
@@ -21,7 +21,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <commonlib/storage.h>
#include "sd_mmc.h"
#include "storage.h"
diff --git a/src/cpu/intel/hyperthreading/intel_sibling.c b/src/cpu/intel/hyperthreading/intel_sibling.c
index e634f85..3c3e53a 100644
--- a/src/cpu/intel/hyperthreading/intel_sibling.c
+++ b/src/cpu/intel/hyperthreading/intel_sibling.c
@@ -17,7 +17,6 @@
#include <device/device.h>
#include <pc80/mc146818rtc.h>
#include <smp/spinlock.h>
-#include <assert.h>

#if CONFIG(PARALLEL_CPU_INIT)
#error Intel hyper-threading requires serialized CPU init
diff --git a/src/cpu/intel/model_206ax/model_206ax_init.c b/src/cpu/intel/model_206ax/model_206ax_init.c
index 85b0937..524e49c 100644
--- a/src/cpu/intel/model_206ax/model_206ax_init.c
+++ b/src/cpu/intel/model_206ax/model_206ax_init.c
@@ -15,7 +15,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <console/console.h>
#include <device/device.h>
#include <arch/acpi.h>
diff --git a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
index 00f6307..e26701b 100644
--- a/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
+++ b/src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <console/console.h>
#include <cpu/cpu.h>
#include <cpu/x86/mp.h>
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c
index be08504..11a5187 100644
--- a/src/drivers/spi/winbond.c
+++ b/src/drivers/spi/winbond.c
@@ -18,7 +18,6 @@
#include <spi_flash.h>
#include <spi-generic.h>
#include <string.h>
-#include <assert.h>
#include <delay.h>
#include <lib.h>

diff --git a/src/lib/gpio.c b/src/lib/gpio.c
index ab473cb..8ea3b5e 100644
--- a/src/lib/gpio.c
+++ b/src/lib/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <base3.h>
#include <console/console.h>
#include <delay.h>
diff --git a/src/mainboard/google/dragonegg/romstage_fsp_params.c b/src/mainboard/google/dragonegg/romstage_fsp_params.c
index e357ee7..f2c6851 100644
--- a/src/mainboard/google/dragonegg/romstage_fsp_params.c
+++ b/src/mainboard/google/dragonegg/romstage_fsp_params.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <baseboard/variants.h>
#include <soc/romstage.h>

diff --git a/src/mainboard/intel/galileo/vboot.c b/src/mainboard/intel/galileo/vboot.c
index 4b1f09f..8b6706c 100644
--- a/src/mainboard/intel/galileo/vboot.c
+++ b/src/mainboard/intel/galileo/vboot.c
@@ -12,7 +12,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <bootmode.h>
#include <device/i2c_simple.h>
#include <soc/i2c.h>
diff --git a/src/northbridge/amd/pi/00630F01/northbridge.c b/src/northbridge/amd/pi/00630F01/northbridge.c
index 2b94daa..eca2f0c 100644
--- a/src/northbridge/amd/pi/00630F01/northbridge.c
+++ b/src/northbridge/amd/pi/00630F01/northbridge.c
@@ -33,7 +33,6 @@
#include <cpu/amd/msr.h>
#include <cpu/amd/mtrr.h>
#include <arch/acpigen.h>
-#include <assert.h>
#include <northbridge/amd/pi/nb_common.h>
#include <northbridge/amd/agesa/agesa_helper.h>
#if CONFIG(BINARYPI_LEGACY_WRAPPER)
diff --git a/src/security/vboot/vbnv_flash.c b/src/security/vboot/vbnv_flash.c
index 85cd04a..908846f 100644
--- a/src/security/vboot/vbnv_flash.c
+++ b/src/security/vboot/vbnv_flash.c
@@ -14,7 +14,6 @@
*/

#include <arch/early_variables.h>
-#include <assert.h>
#include <commonlib/region.h>
#include <console/console.h>
#include <string.h>
diff --git a/src/soc/cavium/cn81xx/ecam0.c b/src/soc/cavium/cn81xx/ecam0.c
index 6e0cb9c..6659cdf 100644
--- a/src/soc/cavium/cn81xx/ecam0.c
+++ b/src/soc/cavium/cn81xx/ecam0.c
@@ -23,7 +23,6 @@
#include <soc/addressmap.h>
#include <soc/cavium/common/pci/chip.h>
#include <soc/ecam.h>
-#include <assert.h>

#define CAVM_PCCPF_XXX_VSEC_CTL 0x108
#define CAVM_PCCPF_XXX_VSEC_SCTL 0x10c
diff --git a/src/soc/cavium/cn81xx/twsi.c b/src/soc/cavium/cn81xx/twsi.c
index d29bcda..7137531 100644
--- a/src/soc/cavium/cn81xx/twsi.c
+++ b/src/soc/cavium/cn81xx/twsi.c
@@ -20,7 +20,6 @@
#include <soc/clock.h>
#include <device/i2c.h>
#include <device/i2c_simple.h>
-#include <assert.h>
#include <delay.h>
#include <device/mmio.h>
#include <soc/addressmap.h>
diff --git a/src/soc/cavium/common/ecam.c b/src/soc/cavium/common/ecam.c
index aaf9085..ae2a91f 100644
--- a/src/soc/cavium/common/ecam.c
+++ b/src/soc/cavium/common/ecam.c
@@ -22,7 +22,6 @@
#include <device/pci.h>
#include <soc/addressmap.h>
#include <soc/ecam.h>
-#include <assert.h>

/**
* Get PCI BAR address from cavium specific extended capability.
diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index 9696a58..6208c9c 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -21,6 +21,7 @@
#include <console/console.h>
#include <device/mmio.h>
#include <arch/smp/mpspec.h>
+#include <assert.h>
#include <device/pci_ops.h>
#include <cbmem.h>
#include <cpu/x86/smm.h>
diff --git a/src/soc/intel/apollolake/gpio_apl.c b/src/soc/intel/apollolake/gpio_apl.c
index 265e613..b76c9b0 100644
--- a/src/soc/intel/apollolake/gpio_apl.c
+++ b/src/soc/intel/apollolake/gpio_apl.c
@@ -15,7 +15,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <intelblocks/gpio.h>
#include <intelblocks/pcr.h>
#include <soc/pcr_ids.h>
diff --git a/src/soc/intel/apollolake/gpio_glk.c b/src/soc/intel/apollolake/gpio_glk.c
index 037273c..99f4e4d 100644
--- a/src/soc/intel/apollolake/gpio_glk.c
+++ b/src/soc/intel/apollolake/gpio_glk.c
@@ -15,7 +15,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <intelblocks/gpio.h>
#include <intelblocks/pcr.h>
#include <soc/pcr_ids.h>
diff --git a/src/soc/intel/apollolake/uart.c b/src/soc/intel/apollolake/uart.c
index 1a31e20..27be4e6 100644
--- a/src/soc/intel/apollolake/uart.c
+++ b/src/soc/intel/apollolake/uart.c
@@ -20,7 +20,6 @@
* shouldn't cause any fragmentation.
*/

-#include <assert.h>
#include <console/console.h>
#include <intelblocks/uart.h>
#include <soc/gpio.h>
diff --git a/src/soc/intel/cannonlake/romstage/romstage.c b/src/soc/intel/cannonlake/romstage/romstage.c
index 893f37d..c168da9 100644
--- a/src/soc/intel/cannonlake/romstage/romstage.c
+++ b/src/soc/intel/cannonlake/romstage/romstage.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <chip.h>
#include <cpu/x86/mtrr.h>
#include <cbmem.h>
diff --git a/src/soc/intel/cannonlake/uart.c b/src/soc/intel/cannonlake/uart.c
index 1b72b24..2bd906a 100644
--- a/src/soc/intel/cannonlake/uart.c
+++ b/src/soc/intel/cannonlake/uart.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <console/console.h>
#include <device/pci_def.h>
#include <intelblocks/gpio.h>
diff --git a/src/soc/intel/common/block/sgx/sgx.c b/src/soc/intel/common/block/sgx/sgx.c
index 3a4a533..2d4cc53 100644
--- a/src/soc/intel/common/block/sgx/sgx.c
+++ b/src/soc/intel/common/block/sgx/sgx.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <console/console.h>
#include <cpu/x86/msr.h>
#include <cpu/x86/mtrr.h>
diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index b89bf6f..a8e5792 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -14,7 +14,6 @@
*/

#include <arch/acpi.h>
-#include <assert.h>
#include <cbmem.h>
#include <console/uart.h>
#include <device/device.h>
diff --git a/src/soc/intel/denverton_ns/gpio.c b/src/soc/intel/denverton_ns/gpio.c
index 30851fd..7c45d40 100644
--- a/src/soc/intel/denverton_ns/gpio.c
+++ b/src/soc/intel/denverton_ns/gpio.c
@@ -16,7 +16,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <intelblocks/gpio.h>
#include <intelblocks/pcr.h>
#include <soc/pcr.h>
diff --git a/src/soc/intel/icelake/romstage/romstage.c b/src/soc/intel/icelake/romstage/romstage.c
index a61370a..b0a2b6c 100644
--- a/src/soc/intel/icelake/romstage/romstage.c
+++ b/src/soc/intel/icelake/romstage/romstage.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <chip.h>
#include <cpu/x86/mtrr.h>
#include <cbmem.h>
diff --git a/src/soc/intel/icelake/uart.c b/src/soc/intel/icelake/uart.c
index 1b72b24..2bd906a 100644
--- a/src/soc/intel/icelake/uart.c
+++ b/src/soc/intel/icelake/uart.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <console/console.h>
#include <device/pci_def.h>
#include <intelblocks/gpio.h>
diff --git a/src/soc/intel/quark/spi.c b/src/soc/intel/quark/spi.c
index 7ffa203..0bd0473 100644
--- a/src/soc/intel/quark/spi.c
+++ b/src/soc/intel/quark/spi.c
@@ -16,7 +16,6 @@

#include <device/mmio.h>
#include <device/pci_ops.h>
-#include <assert.h>
#include <bootstate.h>
#include <console/console.h>
#include <device/pci_ids.h>
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 3e77b03..47d4841 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -15,7 +15,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <arch/cpu.h>
#include <bootstate.h>
#include <console/console.h>
diff --git a/src/soc/intel/skylake/gpio.c b/src/soc/intel/skylake/gpio.c
index 3d66fa4..39cbde6 100644
--- a/src/soc/intel/skylake/gpio.c
+++ b/src/soc/intel/skylake/gpio.c
@@ -14,7 +14,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <intelblocks/gpio.h>
#include <intelblocks/pcr.h>
#include <soc/pcr_ids.h>
diff --git a/src/soc/mediatek/common/include/soc/rtc_common.h b/src/soc/mediatek/common/include/soc/rtc_common.h
index d039e0b..ff5dd34 100644
--- a/src/soc/mediatek/common/include/soc/rtc_common.h
+++ b/src/soc/mediatek/common/include/soc/rtc_common.h
@@ -16,7 +16,6 @@
#ifndef SOC_MEDIATEK_RTC_COMMON_H
#define SOC_MEDIATEK_RTC_COMMON_H

-#include <assert.h>
#include <bcd.h>
#include <console/console.h>
#include <rtc.h>
diff --git a/src/soc/mediatek/common/pmic_wrap.c b/src/soc/mediatek/common/pmic_wrap.c
index 1b8bc5d..6785c0a 100644
--- a/src/soc/mediatek/common/pmic_wrap.c
+++ b/src/soc/mediatek/common/pmic_wrap.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <soc/pmic_wrap.h>
#include <timer.h>

diff --git a/src/soc/mediatek/mt8173/dramc_pi_calibration_api.c b/src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
index 01a32e3..0a8e69b 100644
--- a/src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
+++ b/src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <console/console.h>
#include <stdlib.h>
#include <soc/addressmap.h>
diff --git a/src/soc/mediatek/mt8173/emi.c b/src/soc/mediatek/mt8173/emi.c
index d4cd02a..be84668 100644
--- a/src/soc/mediatek/mt8173/emi.c
+++ b/src/soc/mediatek/mt8173/emi.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <boardid.h>
#include <console/console.h>
#include <soc/addressmap.h>
diff --git a/src/soc/mediatek/mt8173/pmic_wrap.c b/src/soc/mediatek/mt8173/pmic_wrap.c
index 6acaee2..af88343 100644
--- a/src/soc/mediatek/mt8173/pmic_wrap.c
+++ b/src/soc/mediatek/mt8173/pmic_wrap.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <console/console.h>
#include <delay.h>
#include <soc/infracfg.h>
diff --git a/src/soc/mediatek/mt8183/mt6358.c b/src/soc/mediatek/mt8183/mt6358.c
index d338e16..5803271 100644
--- a/src/soc/mediatek/mt8183/mt6358.c
+++ b/src/soc/mediatek/mt8183/mt6358.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <console/console.h>
#include <soc/pmic_wrap.h>
#include <soc/mt6358.h>
diff --git a/src/soc/qualcomm/ipq40xx/i2c.c b/src/soc/qualcomm/ipq40xx/i2c.c
index f5c9943..f20dada 100644
--- a/src/soc/qualcomm/ipq40xx/i2c.c
+++ b/src/soc/qualcomm/ipq40xx/i2c.c
@@ -29,7 +29,6 @@
* IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

-#include <assert.h>
#include <console/console.h>
#include <device/i2c_simple.h>
#include <stdlib.h>
diff --git a/src/soc/qualcomm/ipq806x/i2c.c b/src/soc/qualcomm/ipq806x/i2c.c
index cd57591..c81373f 100644
--- a/src/soc/qualcomm/ipq806x/i2c.c
+++ b/src/soc/qualcomm/ipq806x/i2c.c
@@ -27,7 +27,6 @@
* SUCH DAMAGE.
*/

-#include <assert.h>
#include <console/console.h>
#include <device/i2c_simple.h>
#include <stdlib.h>
diff --git a/src/soc/rockchip/common/edp.c b/src/soc/rockchip/common/edp.c
index 98381a0..91e2de9 100644
--- a/src/soc/rockchip/common/edp.c
+++ b/src/soc/rockchip/common/edp.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <console/console.h>
#include <delay.h>
#include <device/device.h>
diff --git a/src/soc/rockchip/common/pwm.c b/src/soc/rockchip/common/pwm.c
index ad0453b..e5da05e 100644
--- a/src/soc/rockchip/common/pwm.c
+++ b/src/soc/rockchip/common/pwm.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <soc/addressmap.h>
#include <soc/grf.h>
#include <soc/soc.h>
diff --git a/src/soc/rockchip/rk3288/hdmi.c b/src/soc/rockchip/rk3288/hdmi.c
index 425d302..b4de270 100644
--- a/src/soc/rockchip/rk3288/hdmi.c
+++ b/src/soc/rockchip/rk3288/hdmi.c
@@ -20,7 +20,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <console/console.h>
#include <delay.h>
#include <edid.h>
diff --git a/src/soc/rockchip/rk3288/tsadc.c b/src/soc/rockchip/rk3288/tsadc.c
index a34105d..3223a4d 100644
--- a/src/soc/rockchip/rk3288/tsadc.c
+++ b/src/soc/rockchip/rk3288/tsadc.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <soc/clock.h>
#include <soc/grf.h>
#include <soc/pmu.h>
diff --git a/src/soc/rockchip/rk3399/bl31_plat_params.c b/src/soc/rockchip/rk3399/bl31_plat_params.c
index 647566b..9c11552 100644
--- a/src/soc/rockchip/rk3399/bl31_plat_params.c
+++ b/src/soc/rockchip/rk3399/bl31_plat_params.c
@@ -15,7 +15,6 @@
*/

#include <arm_tf.h>
-#include <assert.h>
#include <cbmem.h>
#include <soc/bl31_plat_params.h>

diff --git a/src/soc/rockchip/rk3399/mipi.c b/src/soc/rockchip/rk3399/mipi.c
index ee8cc2e..cc16563 100644
--- a/src/soc/rockchip/rk3399/mipi.c
+++ b/src/soc/rockchip/rk3399/mipi.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <console/console.h>
#include <delay.h>
#include <device/device.h>
diff --git a/src/soc/rockchip/rk3399/tsadc.c b/src/soc/rockchip/rk3399/tsadc.c
index d5aeccd..7ec24648 100644
--- a/src/soc/rockchip/rk3399/tsadc.c
+++ b/src/soc/rockchip/rk3399/tsadc.c
@@ -14,7 +14,6 @@
*/

#include <device/mmio.h>
-#include <assert.h>
#include <delay.h>
#include <soc/clock.h>
#include <soc/grf.h>
diff --git a/src/soc/samsung/exynos5250/alternate_cbfs.c b/src/soc/samsung/exynos5250/alternate_cbfs.c
index 9fef9ae..e431672 100644
--- a/src/soc/samsung/exynos5250/alternate_cbfs.c
+++ b/src/soc/samsung/exynos5250/alternate_cbfs.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <boot_device.h>
#include <console/console.h>
#include <soc/alternate_cbfs.h>
diff --git a/src/soc/samsung/exynos5250/pinmux.c b/src/soc/samsung/exynos5250/pinmux.c
index 10c8c95..9ddbea5 100644
--- a/src/soc/samsung/exynos5250/pinmux.c
+++ b/src/soc/samsung/exynos5250/pinmux.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <console/console.h>
#include <soc/gpio.h>
#include <soc/pinmux.h>
diff --git a/src/soc/samsung/exynos5420/alternate_cbfs.c b/src/soc/samsung/exynos5420/alternate_cbfs.c
index a1e92a0..ba3f9a3 100644
--- a/src/soc/samsung/exynos5420/alternate_cbfs.c
+++ b/src/soc/samsung/exynos5420/alternate_cbfs.c
@@ -14,7 +14,6 @@
*/

#include <arch/cache.h>
-#include <assert.h>
#include <boot_device.h>
#include <console/console.h>
#include <soc/alternate_cbfs.h>
diff --git a/src/soc/samsung/exynos5420/pinmux.c b/src/soc/samsung/exynos5420/pinmux.c
index d8c1378..999afa0 100644
--- a/src/soc/samsung/exynos5420/pinmux.c
+++ b/src/soc/samsung/exynos5420/pinmux.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/

-#include <assert.h>
#include <soc/gpio.h>
#include <soc/pinmux.h>
#include <stdlib.h>
diff --git a/src/superio/renesas/m3885x/superio.c b/src/superio/renesas/m3885x/superio.c
index b200855..522d647 100644
--- a/src/superio/renesas/m3885x/superio.c
+++ b/src/superio/renesas/m3885x/superio.c
@@ -17,7 +17,6 @@
#include <device/pnp.h>
#include <console/console.h>
#include <device/smbus.h>
-#include <assert.h>
#include <stdlib.h>
#include <pc80/keyboard.h>

diff --git a/src/superio/smsc/lpc47n227/early_serial.c b/src/superio/smsc/lpc47n227/early_serial.c
index c02b850..42213b7 100644
--- a/src/superio/smsc/lpc47n227/early_serial.c
+++ b/src/superio/smsc/lpc47n227/early_serial.c
@@ -17,7 +17,9 @@
/* Pre-RAM driver for SMSC LPC47N227 Super I/O chip. */

#include <arch/io.h>
+#include <assert.h>
#include <device/pnp_ops.h>
+
#include "lpc47n227.h"

void pnp_enter_conf_state(pnp_devfn_t dev)

To view, visit change 26796. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Gerrit-Change-Number: 26796
Gerrit-PatchSet: 16
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged