Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Qinghong Zeng, Weimin Wu.
Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/84871?usp=email )
Change subject: mb/google/nissa/var/teliks: Match VBT with SSFC
......................................................................
Patch Set 13: -Code-Review
(1 comment)
File src/mainboard/google/brya/variants/teliks/variant.c:
https://review.coreboot.org/c/coreboot/+/84871/comment/30b191e3_779e995d?usp... :
PS13, Line 100: 6
You are probing for BIT6 (not BIT7) here.
+1 (bit 6 with index 0)
```
/*
* Determine if the panel is 11 inches based on the SSFC register.
*
* Bit 6 of the SSFC register indicates the panel size:
* 0: 13.3 inch panel
* 1: 11 inch panel
*/
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84871?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia8fb45aede5ead4826d983760506c366a70643ee
Gerrit-Change-Number: 84871
Gerrit-PatchSet: 13
Gerrit-Owner: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Derek Huang
derekhuang@google.com
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-CC: Edward Dai
edwarddai@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ricky Chang
rickytlchang@google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 29 Oct 2024 08:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com