Attention is currently required from: Paul Menzel, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50136 )
Change subject: nb/intel/haswell/gma.c: Refactor CdClk init code
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/50136/comment/5f63f311_f2967fc4
PS3, Line 369: * ULX defaults to 337MHz with possible override for 450MHz
: * ULT is fixed at 450MHz
: * others default to 540MHz with possible override for 450MHz
The indentation and alingment looks strange to me.
It's aligning the numbers. I don't remember why I did it this way, but I can see why it looks strange.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa9e9085d5dca0ced7bed4ca8fece139c29bc46c
Gerrit-Change-Number: 50136
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jamal Wright
Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 02 Aug 2021 15:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment