Arthur Heymans has uploaded this change for review.

View Change

soc/intel/common/block/sa: Add compiletime error on undefined SA_PCIE_LENGTH

Change-Id: Ib9facecc4caa869e65f938a55508741dd48b09b0
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
---
M src/soc/intel/common/block/systemagent/Kconfig
M src/soc/intel/common/block/systemagent/systemagent_early.c
2 files changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/35887/1

diff --git a/src/soc/intel/common/block/systemagent/Kconfig b/src/soc/intel/common/block/systemagent/Kconfig
index d7619a0..81a7f9d 100644
--- a/src/soc/intel/common/block/systemagent/Kconfig
+++ b/src/soc/intel/common/block/systemagent/Kconfig
@@ -8,7 +8,6 @@
 	default 0x10000000 if (PCIEX_LENGTH_256MB)
 	default 0x8000000 if (PCIEX_LENGTH_128MB)
 	default 0x4000000 if (PCIEX_LENGTH_64MB)
-	default 0x10000000
 	help
 	  This option allows you to select length of PCIEX region.
 
diff --git a/src/soc/intel/common/block/systemagent/systemagent_early.c b/src/soc/intel/common/block/systemagent/systemagent_early.c
index 8c89c07..5411238 100644
--- a/src/soc/intel/common/block/systemagent/systemagent_early.c
+++ b/src/soc/intel/common/block/systemagent/systemagent_early.c
@@ -26,6 +26,10 @@
 
 #include "systemagent_def.h"
 
+#if CONFIG_SA_PCIEX_LENGTH == 0
+#error "SA_PCIEX_LENGTH undefined!"
+#endif
+
 void bootblock_systemagent_early_init(void)
 {
 	uint32_t reg;

To view, visit change 35887. To unsubscribe, or for help writing mail filters, visit settings.