Hello Aaron Durbin, Patrick Rudolph, Subrata Banik, Balaji Manigandan, Aamir Bohra, Matt DeVillier, Paul Menzel, build bot (Jenkins), Hannah Williams, Lijian Zhao, Furquan Shaikh, Philipp Deppenwiese,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35924
to look at the new patch set (#4).
Change subject: Revert "soc/intel/cannonlake: Remove DMA support for PTT" ......................................................................
Revert "soc/intel/cannonlake: Remove DMA support for PTT"
This reverts commit d5018a8f78b9e1f0b7d3d1be298cba9716b10c6c.
Reason for revert: Breaks boot on Whiskey Lake-U boards
Both System76 and Purism have had memory initialization failures when this patch is applied, with the following error message: Failed to accommodate FSP reserved memory request!
An extra 4096 bytes needs to be reserved for the FSP on these systems, and reinstating the PTT reservation does this as expected. PTT is enabled for the System76 galp3-c in the ME configuration, which is why the behaviour is different.
Signed-off-by: Jeremy Soller jeremy@system76.com CC: Matt DeVillier matt.devillier@gmail.com CC: Subrata Banik subrata.banik@intel.com Change-Id: Ib82f02c4a2b1cd2dbf95d4ca4a9edd314e78edd2 --- M src/soc/intel/cannonlake/include/soc/iomap.h M src/soc/intel/cannonlake/memmap.c 2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35924/4