Attention is currently required from: Anil Kumar K, Bora Guvendik, Hannah Williams, Paul Menzel, Subrata Banik.
6 comments:
File src/soc/intel/common/block/acpi/Kconfig:
nit […]
Done
File src/soc/intel/common/block/acpi/acpi.c:
Patch Set #11, Line 108: fadt->gpe0_blk_len = 2 * GPE0_REG_MAX * sizeof(uint32_t);
move this at line #106?
thx
Patch Set #11, Line 109: !fadt->gpe1_blk
again same mistake. […]
oh. no. thx
Patch Set #11, Line 110: gpe0_blk_len
shouldn't this be `fadt->gpe1_blk_len`
fixed. also, GPE1_REG_MAX.
should be `gpe1_blk_len` as per ACPI spec? […]
Subrata,
gp10_blk_en is correct since its starting bit is right after the end of gpe0.
Also confirmed with BIOS code:
#define EFI_ACPI_GPE1_BASE (EFI_ACPI_GPE0_BLK_BIT_WIDTH / 2)
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
In addition, the following SOC GPE1 defines are required in common
* code but not present in older platform headers. Therefore, the dummy entries
* are added here for platforms without GPE1 support.
move this highlighted comment above line #11 as its applicable there
Done
To view, visit change 84103. To unsubscribe, or for help writing mail filters, visit settings.