Frans Hendriks has uploaded this change for review.

View Change

security/tpm/tss/tcg-2.0/tss.c: Add debug message to tlcl_lib_init()

No message is reported in tlcl_lib_init() when tis_init() or tis_open()
returned an error value.
Add debug string.

BUG=N/A
TEST=Build binary and verified logging on Facebook FBG-1701

Change-Id: I522e488ddd3a1bd94a1a8c8470c757bd79c6d5c5
Signed-off-by: Frans Hendriks <fhendriks@eltan.com>
---
M src/security/tpm/tss/tcg-2.0/tss.c
1 file changed, 7 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/33415/1
diff --git a/src/security/tpm/tss/tcg-2.0/tss.c b/src/security/tpm/tss/tcg-2.0/tss.c
index e579bff..c4b5538 100644
--- a/src/security/tpm/tss/tcg-2.0/tss.c
+++ b/src/security/tpm/tss/tcg-2.0/tss.c
@@ -181,10 +181,15 @@
if (done)
return VB2_SUCCESS;

- if (tis_init())
+ if (tis_init()) {
+ printk(BIOS_ERR, "%s: tis_init returned error\n", __func__);
return VB2_ERROR_UNKNOWN;
- if (tis_open())
+ }
+
+ if (tis_open()) {
+ printk(BIOS_ERR, "%s: tis_open returned error\n", __func__);
return VB2_ERROR_UNKNOWN;
+ }

car_set_var(tlcl_init_done, 1);


To view, visit change 33415. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I522e488ddd3a1bd94a1a8c8470c757bd79c6d5c5
Gerrit-Change-Number: 33415
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com>
Gerrit-MessageType: newchange