View Change
1 comment:
Commit Message:
Patch Set #5, Line 16: fine on at least model_1067x and model_6ex.
> > I'm not an expert, but would feel safer with CD set. Unless there is […]
To be clear, I meant having CD set during the MTRR write. So, clearing it
again afterwards. It just seemed odd to me to change caching while caching
is enabled, but my knowledge is really humble when it comes to caching...
To view, visit change 35993. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94d5771a57ffd74d53db3e35fe169d77d7fbb8cd
Gerrit-Change-Number: 35993
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan@google.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 22 Oct 2019 21:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment